| CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Disable lint suggestions on my PRs #138054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138054
Note: Links to docs will display an error until the docs builds have been completed. âś… No FailuresAs of commit 4ec0b8e with merge base fe43f72 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
albanD,
antoniojkim,
bdhirsh,
miladm and
SherlockNoMad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just FYI, there is an issue to improve the UX here pytorch/test-infra#5760. But, till it's done, opt-out it is then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -12,7 +12,7 @@ jobs: | |||
| contents: read | |||
| pull-requests: write | |||
| runs-on: lf.linux.2xlarge | |||
| if: ${{ github.repository_owner == 'pytorch' }} | |||
| if: ${{ github.repository_owner == 'pytorch' && github.event.pull_request.user.login != 'ezyang' }} | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please...
| if: ${{ github.repository_owner == 'pytorch' && github.event.pull_request.user.login != 'ezyang' }} | |
| if: ${{ github.repository_owner == 'pytorch' && github.event.pull_request.user.login != 'ezyang' && github.event.pull_request.user.login != 'malfet' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just not run them on draft PRs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be the right solution is just to disable the workflow or make it an opt-in. Or perhaps run it only if your workflows needs approval...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a sensible opt-in strategy is have the lint error ci message say "to suggest these as changes on your PR, comment BLAH" and then the flow triggers on that
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
The suggestions unusably clog up early draft PRs that are not necessarily lint clean yet. Making matters worse, even if I fix them I have to manually click through hundreds of comments to "Resolve" them even though I've fixed it. Disabling it on ghstack helps, but I occasionally do standard PRs via fbcode export mechanism. Opt me out. Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch#138054 Approved by: https://github.com/huydhn, https://github.com/malfet, https://github.com/PaliC
Stack from ghstack (oldest at bottom):
The suggestions unusably clog up early draft PRs that are not necessarily lint clean yet. Making matters worse, even if I fix them I have to manually click through hundreds of comments to "Resolve" them even though I've fixed it. Disabling it on ghstack helps, but I occasionally do standard PRs via fbcode export mechanism. Opt me out.
Signed-off-by: Edward Z. Yang ezyang@meta.com