| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 20 Jul 2025 05:43:34 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=1434.027808,conversation_content-fragment;desc="conversation_content fragment";dur=1336.993858,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=322.214533,nginx;desc="NGINX";dur=0.80054,glb;desc="GLB";dur=98.260459
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=c2y6Fcu9ZPqkEOyEMhtSQm1mMIgQaJwHHzxorVuJ074VxIVFC2y1apC6ZiQFA1hp%2BtiWxDDOQPhPLAfj63WYJ7iCaHLT7V%2BxoojBYL7e4cZJmCl3gsVwzeblCDZxBgnUkcXzf5CrmjptUZ3yQNfP7Hx4WxKzKvJgUJYNcHsFdZLEJSlRbIE8p%2BeDxD3qlKr5ebyvCs7wJy2wB6xdhzaWWdS%2FXSooKkjTluuGIOVDM1omIc7muQu5uAfsPxfEYZlPed5%2B7fojUZt9qX83K1Wpvw%3D%3D--figJHl00u1cGTtTi--y4f1XwNtCdumrNgasBZTag%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1474969300.1752990212; Path=/; Domain=github.com; Expires=Mon, 20 Jul 2026 05:43:32 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 20 Jul 2026 05:43:32 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D956:E3E22:D6C9C2:11BB4AD:687C8204
Fix assigning tensor with requires_grad as constant in export by tugsbayasgalan · Pull Request #137997 · pytorch/pytorch · GitHub
tugsbayasgalan
requested review from
avikchaudhuri,
zhxchen17,
ydwu4 and
angelayi
as code owners
October 15, 2024 16:57
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Fix assigning tensor with requires_grad as constant in export #137997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
tugsbayasgalan
wants to merge
5
commits into
gh/tugsbayasgalan/256/base
from
gh/tugsbayasgalan/256/head
Closed
Fix assigning tensor with requires_grad as constant in export #137997
tugsbayasgalan
wants to merge
5
commits into
gh/tugsbayasgalan/256/base
from
gh/tugsbayasgalan/256/head
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we insert cojstants into unlifted graph, we need to detach them if they require grad. Differential Revision: [D64406859](https://our.internmc.facebook.com/intern/diff/D64406859/) [ghstack-poisoned]
tugsbayasgalan
requested review from
avikchaudhuri,
zhxchen17,
ydwu4 and
angelayi
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137997
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a9a5da7 with merge base f173623 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D64406859 |
tugsbayasgalan
added a commit
that referenced
this pull request
Oct 15, 2024
When we insert cojstants into unlifted graph, we need to detach them if they require grad. Differential Revision: [D64406859](https://our.internmc.facebook.com/intern/diff/D64406859/) ghstack-source-id: 248115756 Pull Request resolved: #137997
avikchaudhuri
requested changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test please
…ort" When we insert cojstants into unlifted graph, we need to detach them if they require grad. Differential Revision: [D64406859](https://our.internmc.facebook.com/intern/diff/D64406859/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D64406859 |
tugsbayasgalan
added a commit
that referenced
this pull request
Oct 15, 2024
Pull Request resolved: #137997 When we insert cojstants into unlifted graph, we need to detach them if they require grad. Differential Revision: [D64406859](https://our.internmc.facebook.com/intern/diff/D64406859/) ghstack-source-id: 248221115
…ort" When we insert cojstants into unlifted graph, we need to detach them if they require grad. Differential Revision: [D64406859](https://our.internmc.facebook.com/intern/diff/D64406859/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D64406859 |
avikchaudhuri
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase and check CI before landing...
torch/export/_unlift.py
Outdated
| @@ -309,6 +318,19 @@ def _create_stateful_graph_module( | |||
| for const_name, value in ep.constants.items(): | |||
| if not torch.fx.graph_module._has_attr(stateful_gm, const_name): | |||
| if isinstance(value, torch.Tensor): | |||
| if value.requires_grad: | |||
| warnings.warn( | |||
| f"A model attribute `{const_name}` requires gradient. " | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no ending period
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sg
| if value in original_tensor_to_detached_tensor: | ||
| value = original_tensor_to_detached_tensor[value] | ||
| else: | ||
| detached_value = value.detach() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this code should be refactored into a util?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is bit hard to make it a util because this is only relevant in this specific location.
…ort" When we insert cojstants into unlifted graph, we need to detach them if they require grad BUT when we detach we need to preserve the original aliasing information. Differential Revision: [D64406859](https://our.internmc.facebook.com/intern/diff/D64406859/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D64406859 |
…ort" When we insert cojstants into unlifted graph, we need to detach them if they require grad BUT when we detach we need to preserve the original aliasing information. Differential Revision: [D64406859](https://our.internmc.facebook.com/intern/diff/D64406859/) [ghstack-poisoned]
tugsbayasgalan
added a commit
that referenced
this pull request
Oct 16, 2024
Pull Request resolved: #137997 When we insert cojstants into unlifted graph, we need to detach them if they require grad. ghstack-source-id: b218468 Differential Revision: [D64406859](https://our.internmc.facebook.com/intern/diff/D64406859/)
|
@tugsbayasgalan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Stack from ghstack (oldest at bottom):
When we insert cojstants into unlifted graph, we need to detach them if they require grad BUT when we detach we need to preserve the original aliasing information.
Differential Revision: D64406859