| CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Updates reference to _runner-determinator.yml workflow, from current version to main version. #137791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jeanschmidt
added
ciflow/trunk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it prevent people from being able to test any changes to this workflow on the pull request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I wonder why we don't move this to test-infra, but this probably makes more sense as this is a PyTorch-only thing. If we need some tests here, we need to write a test workflow like https://github.com/pytorch/test-infra/blob/main/.github/workflows/test-setup-nvidia.yml that calls the GHA from PR head.
Yes. The workaround would be they update their PR to use the local version for testing but then runs the risk of folks needing to remember to remove that from their workflow before approving and merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me.
|
@pytorchbot merge -i |
Merge failedReason: 1 mandatory check(s) are pending/not yet run. The first few are:
Dig deeper by viewing the pending checks on hud |
|
@pytorchbot merge -f "easycla job does not exist" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) are pending/not yet run. The first few are:
Dig deeper by viewing the pending checks on hud |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
…version to main version.
|
Successfully rebased |
pytorchmergebot
force-pushed
the
jeanschmidt/runner_determinator_from_main
branch
from
f8c6793 to
0e19f23
Compare
|
@pytorchbot merge -f 'CI only changes, runner determinator and lint jobs have passed' |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
EasyCLA job does exist and I've seen it pass in other PRs. Its a job managed by the LF for all open source projects. I wonder why its missing here but we shouldn't ignore it. |
|
@zxiiro totally agree, we should not even allow I did rebase expecting it to run, and didn't try to |
github-actions
bot
deleted the
jeanschmidt/runner_determinator_from_main
branch
Updates all references to runner determinator workflow (
_runner-determinator.yml) from current cloned version to main version.This enables the team to push updates to this workflow, like fixing bugs or pushing improvements, and have it immediately be reflected on all open PRs. So avoiding potentially breaking situations, empowering moving fast and fast and simple recover in case of bugs.
From:
To: