CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Pass all arguments when quantizing embedding bag from float #137697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137697
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 55a7d9f with merge base 4dd04db ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "module: arm" |
@pytorchbot label "module: arm" |
@malfet Could I please get a review ? Thank you. |
hi, can you please rebase this PR to the latest viable/strict branch? This one is pulling in some old code that is stopping you from getting a clean CI run |
(commenting here with just |
@pytorchmergebot rebase |
You don't have permissions to rebase this PR since you are a first time contributor. If you think this is a mistake, please contact PyTorch Dev Infra. |
@pytorchmergebot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
cdcb828
to
a7b7654
Compare
Hi @annop-w , please fix the linter failure.
|
@snadampal Done. |
@malfet @digantdesai Could this now be merged ? Thank you. |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…137697) Pull Request resolved: pytorch#137697 Approved by: https://github.com/snadampal, https://github.com/jerryzh168
…137697) Pull Request resolved: pytorch#137697 Approved by: https://github.com/snadampal, https://github.com/jerryzh168
…137697) Pull Request resolved: pytorch#137697 Approved by: https://github.com/snadampal, https://github.com/jerryzh168
cc @malfet @snadampal @milpuz01