In MemoryPlanningInfoForBuffer, I am only keeping the attributes that are static. For dynamically set attributes (e.g., outdegree), will keep track of them during the function that needs them.

Similarly, removed e.g., memory_to_free and indegree from MemoryPlanningInfoForNode.

Did we do a dashboard run yet ? could we do that before landing ?

it's easiest to do via ghstack but i think you can also push to origin/main or something I forget exactly. would recommend ghstack.

If you've already submitted this pr, the easiest to do that is just to git reset --soft HEAD~1; git commit -m "tmp" ; ghstack and benchmark this commit as another pr.

Let me try to figure this out.

Sorry one other thing - we should test out the various implementations on ci runs as well, if possible. unless you already have clear idea that one is pareto optimal (compilation time, average memory change, worst memory change).

I submitted a run here. Seems that it takes a few days for the results to show up in the dashboard. I will report back once the results show up.

if we are at all worried about riskiness of change it can also make sense to add a JK for enablement, or enable in OSS first then fbcode

I was initially very concerned about this, but as I am trying this flag on for more internal models, I am becoming less concerned. Though there are many potential situations I am not aware of, so I think it would be the best to leave this decision to the PyTorch team. You guys are are the experts here :) One possibility is that once we turn it on, I can monitor it carefully for a while?

Seems all the dashboard run are done. This is the screenshot for the the summary (seems nothing is signficant).

Individual breakdowns can be found here:

• gh/xuanzhang816/1/head -- using all three heuristics
  • torchbench
  • huggingface
  • timm
• gh/xuanzhang816/2/head -- lpmf only
  • torchbench
  • huggingface
  • timm
• gh/xuanzhang816/3/head -- bfs only
  • torchbench
  • huggingface
  • timm
• gh/xuanzhang816/4/head -- dfs only
  • torchbench
  • huggingface
  • timm