🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136655

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1369a0c with merge base b7a5c7d ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

To summarize Is this N (the cache limit limit) + 1 the cache hit test?

@bhack please clarify what you mean?

Is run only just an extra step for cache hit check after the recompilation limit is exhausted? Or is it something else?

Run only mode is where we do not ever trace bytecode. We try to run previously compiled code and if all guard checks for previously compiled code fail, we run eager. In the case that cache limit is hit and there is no valid previously compiled code, we also disable the eval frame callback so we skip tracing any recursive calls.

@pytorchbot merge

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Just to understand. Earlier, if we hit cache size limit, we fully go back to eager.
Now at runtime, we will still try to use those compiled 8 graphs. But if there is a recompilation, we decide to recursively skip. If yes, this is definitely an improvement. Thanks for the fix.