| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 19 Jul 2025 15:15:17 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=368.949793,conversation_content-fragment;desc="conversation_content fragment";dur=1266.75005,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=407.466114,nginx;desc="NGINX";dur=1.373076,glb;desc="GLB";dur=100.788158
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=mrAP3E8i0P%2B0AKAtPYuN4tzS7s%2BIXmM0FQBgs%2F0%2Bky%2BNZvjD93AzOmfqrQXcwNl%2FmMLYW0Ixkjy4Lds4GMwy7yOz70jwZPe5YNbAXJUU6mG582gV2fhaniTrJ%2Bq4L8y5MEUCo8Bv6OPlpfTgZ%2BkxGVxReUlZWPZR1J3sBIudTiPidBgNWBtd0Cgd3WTHe6e7AK92ZqDcXGYKUCM8BLh%2BVASeF%2BIBGn1AhX5XW1GIyWBkP6mIih5TS9RrmhLQD2CU3ukwjvaxqnXFpkftClUHvg%3D%3D--0hsj5lbFXtJzfCzs--Bwwz9R3lfbLErdQao4IpPg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.103058628.1752938115; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 15:15:15 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 15:15:15 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A9EC:35CC93:4126E4:5094D1:687BB683
Use amazon linux 2023 runners for Docker builds by atalman · Pull Request #136544 · pytorch/pytorch · GitHub
ZainRizvi
dismissed
their stale review
September 25, 2024 16:36
atalman
force-pushed
the
use_amazon2_docker
branch
from
September 25, 2024 18:07
atalman
force-pushed
the
use_amazon2_docker
branch
from
September 25, 2024 19:55
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Use amazon linux 2023 runners for Docker builds #136544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136544
Note: Links to docs will display an error until the docs builds have been completed. âś… You can merge normally! (4 Unrelated Failures)As of commit be8ec13 with merge base eac04fe ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ZainRizvi
previously approved these changes
Sep 24, 2024
ZainRizvi
dismissed
their stale review
dismissing until the docker builds actually work
malfet
reviewed
Sep 25, 2024
atalman
force-pushed
the
use_amazon2_docker
branch
from
b0ba475 to
6863c4c
Compare
atalman
force-pushed
the
use_amazon2_docker
branch
from
537d542 to
e618fc4
Compare
ZainRizvi
reviewed
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not resolve the fix in test-infra first and then merge the pytorch PR after it starts consuming those test-infra changes? That would help test the changes in a clean environment
.ci/docker/conda/Dockerfile
Outdated
| @@ -5,6 +5,7 @@ FROM centos:7 as base | |||
| ENV LC_ALL en_US.UTF-8 | |||
| ENV LANG en_US.UTF-8 | |||
| ENV LANGUAGE en_US.UTF-8 | |||
| RUN echo "ulimit is $(ulimit -n)" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove
malfet
reviewed
Sep 25, 2024
ZainRizvi
approved these changes
Sep 25, 2024
|
@pytorchbot merge -f "Lint is green, let's test it in prod..." |
ZainRizvi
approved these changes
Sep 25, 2024
| @@ -37,6 +37,12 @@ esac | |||
|
|
|||
| ( | |||
| set -x | |||
| # TODO: Remove LimitNOFILE=1048576 patch once https://github.com/pytorch/test-infra/issues/5712 | |||
| # is resolved. This patch is required in order to fix timing out of Docker build on Amazon Linux 2023. | |||
| sudo sed -i s/LimitNOFILE=infinity/LimitNOFILE=1048576/ /usr/lib/systemd/system/docker.service | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: please add a link to the issue that you discovered which explains the problem in more detail
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
BoyuanFeng
pushed a commit
to BoyuanFeng/pytorch
that referenced
this pull request
Sep 25, 2024
Migrate these builds to linux 2023. We want to build and test the Docker images in CD. Looks like we are hitting this issue: docker/buildx#379 when trying to build Docker on Amazon Linux 2023. Conda Docker build is timing out. While Manywheel is executing but failing because BUILDKIT is turned off: https://github.com/pytorch/pytorch/actions/runs/11036043157/job/30653543264?pr=136544 Proposed Solution is to fix it in user_data . Please see: pytorch/test-infra#5712 I see docker builds are executed successfully here: https://github.com/pytorch/pytorch/actions/runs/11040149229/job/30667448668?pr=136544 Workaround timeout problem (reported in https://bugzilla.redhat.com/show_bug.cgi?id=1537564 ) by configuring number of open files per container to 1048576 Pull Request resolved: pytorch#136544 Approved by: https://github.com/ZainRizvi Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Migrate these builds to linux 2023. We want to build and test the Docker images in CD.
Looks like we are hitting this issue: docker/buildx#379 when trying to build Docker on Amazon Linux 2023.
Conda Docker build is timing out. While Manywheel is executing but failing because BUILDKIT is turned off: https://github.com/pytorch/pytorch/actions/runs/11036043157/job/30653543264?pr=136544
Proposed Solution is to fix it in user_data . Please see: pytorch/test-infra#5712
I see docker builds are executed successfully here: https://github.com/pytorch/pytorch/actions/runs/11040149229/job/30667448668?pr=136544
Workaround timeout problem (reported in https://bugzilla.redhat.com/show_bug.cgi?id=1537564 ) by configuring number of open files per container to 1048576