| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 19 Jul 2025 15:14:32 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=391.626999,conversation_content-fragment;desc="conversation_content fragment";dur=808.648278,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=327.984852,nginx;desc="NGINX";dur=1.238044,glb;desc="GLB";dur=101.485003
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=VxlZ2qutlcznw6MVqT5pVopMzrX8Gwyw3XciPYleYxkTktS0sWCLqmFV9QTxFzgdmY0ER7NjzI%2FltwRJszo7xpALpcqMUrTX%2FxgDFUeVVSEYZB6mNVRcvybrv3Gc9%2BWhYtfqMiaMnfjX%2BX7jdzLtglhsxxBh%2F2tGEAQWb%2FWoy%2BQ9Kbsa4BZgmxho4I7oqS3IstJMtofsT9Yc%2Fa1aU%2B%2BVLVqihtGB1H2s7GnPwHPUJXM1LHBQp6puW5rePteO9DBYWarHByW%2B5%2F8zJxhD64HxxQ%3D%3D--aLjGrnphkSrnyrVm--GQnqPdEcdONHsIU5J9iTLA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.475728406.1752938071; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 15:14:31 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 15:14:31 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C496:3DC509:5F60EC:7776E3:687BB657
Add wait counter for nccl abort by atuljangra · Pull Request #136067 · pytorch/pytorch · GitHub
pytorch-bot
bot
added
oncall: distributed
Add this issue/PR to distributed oncall triage queue
release notes: distributed (c10d)
release notes category
labels
Sep 14, 2024
atuljangra
force-pushed
the
export-D62675010
branch
from
September 17, 2024 18:39
atuljangra
force-pushed
the
export-D62675010
branch
from
September 17, 2024 18:48
atuljangra
force-pushed
the
export-D62675010
branch
from
September 17, 2024 18:53
atuljangra
force-pushed
the
export-D62675010
branch
from
September 17, 2024 19:29
atuljangra
force-pushed
the
export-D62675010
branch
from
September 17, 2024 19:35
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Add wait counter for nccl abort #136067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Add wait counter for nccl abort #136067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136067
Note: Links to docs will display an error until the docs builds have been completed. âś… No FailuresAs of commit 75445cc with merge base 48d18fb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
oncall: distributed
|
This pull request was exported from Phabricator. Differential Revision: D62675010 |
fduwjj
approved these changes
Sep 14, 2024
|
@atuljangra do you mind adding a brief comment above the code describing what the code does? |
|
@kwen2501 Added some more details int eh description. |
|
@atuljangra Thanks. Maybe I confused you :) What I meant was to copy the PR description into the code as a comment (so that readers know what that line of code is for). |
|
@kwen2501 Ah got it, will update. |
atuljangra
force-pushed
the
export-D62675010
branch
from
1717e5d to
fa00385
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62675010 |
atuljangra
force-pushed
the
export-D62675010
branch
from
fa00385 to
f660774
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62675010 |
atuljangra
force-pushed
the
export-D62675010
branch
from
f660774 to
4d5f6c6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62675010 |
atuljangra
force-pushed
the
export-D62675010
branch
from
4d5f6c6 to
1fb266f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62675010 |
Summary: Pull Request resolved: pytorch#136067 Quite a few times, we see the NCCL PG abort taking too long. There's no easy way to measure this, so let's add a counter to measure this across the stack. Example job where this would have been useful: f641288746-TrainingApplication Test Plan: Unit tests https://www.internalfb.com/mlhub/pipelines/runs/mast/aps-atuljangra-8519d57d57?job_attempt=0&env=PRODUCTION Reviewed By: c-p-i-o Differential Revision: D62675010
atuljangra
force-pushed
the
export-D62675010
branch
from
1fb266f to
75445cc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62675010 |
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
Summary: Quite a few times, we see the NCCL PG abort taking too long. There's no easy way to measure this, so let's add a counter to measure this across the stack. This will help us measure how much time we take the NCCL abort. Test Plan: Unit tests Reviewed By: c-p-i-o Differential Revision: D62675010 Pull Request resolved: pytorch#136067 Approved by: https://github.com/fduwjj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/trunk
Trigger trunk jobs on your pull request
fb-exported
Merged
oncall: distributed
Add this issue/PR to distributed oncall triage queue
release notes: distributed (c10d)
release notes category
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Summary:
Quite a few times, we see the NCCL PG abort taking too long. There's no easy way to measure this, so let's add a counter to measure this across the stack.
This will help us measure how much time we take the NCCL abort.
Test Plan:
Unit tests
Reviewed By: c-p-i-o
Differential Revision: D62675010
cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o