| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 19 Jul 2025 15:15:07 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=460.187281,conversation_content-fragment;desc="conversation_content fragment";dur=1303.414195,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=414.128464,nginx;desc="NGINX";dur=1.042067,glb;desc="GLB";dur=101.352017
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=%2FxmprZ4jQNnVnlKyoeT3y%2BcfIUwb6%2Bs2AhcZ8UaKLOPrs%2Bak0MLchjDq9wXwJe41zSfn%2BF2GZQURmq5AA70oHO%2BlhtZwFRkQ2CdUlJdBX5rc5Jk52D4B3NSUZS6qw2shqTTPhKFrPN7JXUsklP7U3Azw6ot%2Buumc2Z2HgulAIz8sOtpduUFiciqwXeJy%2Fya2cw3s1XIM%2FVKmuHcnuyOCEf3dMBFSymY%2FdcapajjxfAb719pgzu0WEcgqik3QOITta%2B%2BkI7YWvkQ%2Fws%2FKcl9qrQ%3D%3D--UX9sPSQTtLvcaQ07--rRSf%2BB0boc9Y19yX2JxW4g%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.53486042.1752938106; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 15:15:06 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 15:15:06 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A8FA:10A6BA:5F6E60:778D5D:687BB67A
[export] Deserialize args with python keyword names by angelayi · Pull Request #136036 · pytorch/pytorch · GitHub
angelayi
requested review from
avikchaudhuri,
tugsbayasgalan,
zhxchen17 and
ydwu4
as code owners
September 13, 2024 18:54
angelayi
force-pushed
the
angelayi/deserialize_keyword
branch
from
September 13, 2024 20:07
angelayi
added
bug
release notes: export
topic: bug fixes
topic category
and removed
bug
labels
Sep 13, 2024
angelayi
changed the title
[export] Deserialize args with keyword names
[export] Deserialize args with python keyword names
Sep 13, 2024
angelayi
force-pushed
the
angelayi/deserialize_keyword
branch
from
September 13, 2024 21:25
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 24.7k
[export] Deserialize args with python keyword names #136036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelayi
requested review from
avikchaudhuri,
tugsbayasgalan,
zhxchen17 and
ydwu4
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136036
Note: Links to docs will display an error until the docs builds have been completed. âś… No FailuresAs of commit 35280a8 with merge base 66db61f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
angelayi
force-pushed
the
angelayi/deserialize_keyword
branch
from
4f4a621 to
d018277
Compare
|
@angelayi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
angelayi
added
bug
release notes: export
topic: bug fixes
angelayi
changed the title
angelayi
force-pushed
the
angelayi/deserialize_keyword
branch
from
d018277 to
35280a8
Compare
|
@angelayi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
I mean I can accept this as a short term measure, but why this schema has a keyable argument with keyword name in this first place... Does that mean no one will ever be able to use this argument with the name in Python? |
|
@zhxchen17 I think it's probably a bug that the op's schema has a kwarg with a keyword name, or it was not expected to be used this way, since it seems like the op was added into native_functions.yaml long long ago |
zhxchen17
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok :(
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
Currently when we deserialize inputs to nodes, we deserialize arguments with default values as kwargs. So deserializing `aten.uniform`, which has the signature `uniform(Tensor(a!) self, float from=0, float to=1, *, Generator? generator=None) -> Tensor(a!)`, will get become `uniform(x, from=0, to=1)`. However, this fails when running in python because `from` is a python keyword. So the solution here is to not deserialize it as a kwarg. Pull Request resolved: pytorch#136036 Approved by: https://github.com/zhxchen17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Currently when we deserialize inputs to nodes, we deserialize arguments with default values as kwargs. So deserializing
aten.uniform, which has the signatureuniform(Tensor(a!) self, float from=0, float to=1, *, Generator? generator=None) -> Tensor(a!), will get becomeuniform(x, from=0, to=1). However, this fails when running in python becausefromis a python keyword. So the solution here is to not deserialize it as a kwarg.