CARVIEW |
Select Language
HTTP/2 200
date: Sun, 20 Jul 2025 02:43:13 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=387.889077,conversation_content-fragment;desc="conversation_content fragment";dur=682.325122,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=293.422343,nginx;desc="NGINX";dur=1.362737,glb;desc="GLB";dur=95.879843
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=6NpboyyFURzxKAo%2BLV5Wii7D%2Bn%2FHAxViz9ZtwEWprCS5SQfXVSNukO0vuiBwYwCFE5MTfP%2FJA%2B1eGIPxJWt3pcXvAy8YsPKd9g84ITETF9vooKUeLxD14fyz5vNpJCm85NxeSq0FC6tEsBJrPotyzxHHvfJIj7D5IWPdx0ZI6ECMudUjQtmGjR76MI%2FbWgQ2WChkHaX%2BFqNqv%2BThzNN3QixDYs3VV3r86rJmqb%2F9JYRfSlPLuyPRNocFrbsjmZZwWP0IlqYlsZ5Q99JaACX%2Bhw%3D%3D--cQ5F6ajkk9l847Kv--uYz%2F48IUj3MqbqzqH39zSw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1536479297.1752979392; Path=/; Domain=github.com; Expires=Mon, 20 Jul 2026 02:43:12 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 20 Jul 2026 02:43:12 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: AB44:FD994:C5AFDC:104EF59:687C57C0
Hide protocol object behind the Connection by bigmontz · Pull Request #1139 · neo4j/neo4j-javascript-driver · GitHub
bigmontz
force-pushed
the
5.13-refactory-connection
branch
from
September 7, 2023 15:03
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 152
Hide protocol object behind the Connection #1139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The connection in the driver is exposing the protocol object, which is not great. Improve this part of the code can be done by make the connection object have methods to do high level requests to the server. List of calls the core driver does using the protocol, by passing the connection: * `version` * `run` * `beginTransaction` * `commitTransaction` * `rollbackTransaction` Methods is present in the `Connection` interface (used by core in **bold**): * `id` * `database` * `server` * `authToken` * `address` * `version` * `supportsReAuth` * **`isOpen`** * **`protocol`** * `connect` * `write` * **`resetAndFlush`** * **`hasOngoingObservableRequests`** * **`_release`** So, `isOpen`, `resetAndFlush` and `hasOngoingObservableRequests` are the methods which will stay in the connection along with the new methods. The method `release` will move the a `Releasable` interface, which will be composed with `Connection` when returning the connection from the provider. The `Releasable` interface is also defined to enable the `ConnectionProvider` returns a connection which can be released back to the pool. Internally, `bolt-connection` can keep exposing the internal of the connection outside the connection in a first moment. The full encapsulation of the `protocol` should be done in the next phase of refactoring.
2174247
to
ae5043a
Compare
robsdedude
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an added bonus, I like how the new structure makes the mocking in tests cleaner as well 🙌
Co-authored-by: Robsdedude <dev@rouvenbauer.de>
…re connection The method _acquireConnection and _run methods were replicating the same logic. The logic was extracted to a common method avoid duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
The connection in the driver is exposing the protocol object, which is not great. Improve this part of the code can be done by make the connection object have methods to do high level requests to the server.
List of calls the core driver does using the protocol, by passing the connection:
version
run
beginTransaction
commitTransaction
rollbackTransaction
Methods is present in the
Connection
interface (used by core in bold):id
database
server
authToken
address
version
supportsReAuth
isOpen
protocol
connect
write
resetAndFlush
hasOngoingObservableRequests
_release
So,
isOpen
,resetAndFlush
andhasOngoingObservableRequests
are the methods which will stay in the connection along with the new methods. The methodrelease
will move the aReleasable
interface, which will be composed withConnection
when returning the connection from the provider.The
Releasable
interface is also defined to enable theConnectionProvider
returns a connection which can be released back to the pool.Internally,
bolt-connection
can keep exposing the internal of the connection outside the connection in a first moment. The full encapsulation of theprotocol
should be done in the next phase of refactoring.