| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 20 Jul 2025 10:24:08 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=415.321212,conversation_content-fragment;desc="conversation_content fragment";dur=608.835762,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=270.61941,nginx;desc="NGINX";dur=1.407935,glb;desc="GLB";dur=95.981026
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=9LCXHAt47FMBdaPqNSjPSKx846LPtUXiY7140y3XwnuMl08uEeZPqb5MBPzfOzNPKp8lz8vtR3JPA6gfAWIXR%2FC%2FvDyiaGnDTuJzqPl5OGkopkpg%2Fu%2Bxgq0StCXawRmuBZhnEdSphzQo3IH%2F7CkshQgr3K3dIorxYtFI7MN3ZTlkMHoKgiaK5ZbcTsxyjZeqAAfW%2B0QKp7%2F4X5KZ6gKAqpguD%2Fr%2Blk8gjijw1srAi4u%2BQ2en4g0yofHnb%2FCitqJVw2IWPHZQjE97GRXPWjYC3A%3D%3D--a7p5Sp3BGRthOHIO--LqFN9nw%2F61%2FVCeaG77rGEw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.527319120.1753007047; Path=/; Domain=github.com; Expires=Mon, 20 Jul 2026 10:24:07 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 20 Jul 2026 10:24:07 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B118:21B12E:CC0065:108576A:687CC3C7
Clear receive timeout when close browser and Deno channels by bigmontz · Pull Request #1016 · neo4j/neo4j-javascript-driver · GitHub
bigmontz
force-pushed
the
5.x-remove-temporal-test-flakyness
branch
3 times, most recently
from
November 17, 2022 09:29
bigmontz
force-pushed
the
5.x-remove-temporal-test-flakyness
branch
from
November 17, 2022 10:25
bigmontz
changed the title
Remove random temporal types test flakynes
Clear receive timeout when close browser and Deno channels
Nov 17, 2022
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 152
Clear receive timeout when close browser and Deno channels #1016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bigmontz
merged 4 commits into
neo4j:5.0
from
bigmontz:5.x-remove-temporal-test-flakyness
Nov 18, 2022
Merged
Clear receive timeout when close browser and Deno channels #1016
bigmontz
merged 4 commits into
neo4j:5.0
from
bigmontz:5.x-remove-temporal-test-flakyness
Nov 18, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigmontz
force-pushed
the
5.x-remove-temporal-test-flakyness
branch
3 times, most recently
from
2730056 to
909e4c4
Compare
The receive timeout was not being clearer when channel get closed. With the timeout running, receive timeouts events can still be notified to the existing observers. This was causing some tests failing and possibile issues in production code.
bigmontz
force-pushed
the
5.x-remove-temporal-test-flakyness
branch
from
909e4c4 to
f00ca69
Compare
bigmontz
changed the title
robsdedude
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⏱️ 🔨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
The receive timeout was not being clearer when channel get closed.
With the timeout running, receive timeouts events can still be notified to the existing observers.
This was causing some tests failing and possible issues in production code.
This bug was found in the test
package/neo4j-driver/test/result.test.js (should handle missing onCompleted). This test was callingdonetwice because of a late failing coming to the observer.Node channels are not affected by this error since its timeout implementation is controlled to the socket.