Fail fast for more rediscovery failures (#1011)

bigmontz · web-flow · commit ee72ed068de9 · 2022-12-06T16:55:43.000+01:00
When trying to impersonate an invalid user, the routing procedure returns `Neo.ClientError.Statement.ArgumentError`. This type of failure is not in the fail fast list, thus this is wrapped up in the generic rediscovery error triggering the retry in the transaction functions. Since this kind of error is not recoverable, retrying on it is not need and desirable.

Then, failing fast on `Neo.ClientError.Statement.ArgumentError` failures speeds up the error bubbling and avoids unnecessary load in the client and server.

Other rediscovery failures to be fast failed are:

* `Neo.ClientError.Statement.TypeError`
* `Neo.ClientError.Request.Invalid`
diff --git a/packages/bolt-connection/src/connection-provider/connection-provider-routing.js b/packages/bolt-connection/src/connection-provider/connection-provider-routing.js
@@ -48,6 +48,9 @@ const INVALID_BOOKMARK_MIXTURE_CODE =
   'Neo.ClientError.Transaction.InvalidBookmarkMixture'
 const AUTHORIZATION_EXPIRED_CODE =
   'Neo.ClientError.Security.AuthorizationExpired'
+const INVALID_ARGUMENT_ERROR = 'Neo.ClientError.Statement.ArgumentError'
+const INVALID_REQUEST_ERROR = 'Neo.ClientError.Request.Invalid'
+const STATEMENT_TYPE_ERROR = 'Neo.ClientError.Statement.TypeError'
 
 const SYSTEM_DB_NAME = 'system'
 const DEFAULT_DB_NAME = null
@@ -703,7 +706,10 @@ function _isFailFastError (error) {
   return [
     DATABASE_NOT_FOUND_CODE,
     INVALID_BOOKMARK_CODE,
-    INVALID_BOOKMARK_MIXTURE_CODE
+    INVALID_BOOKMARK_MIXTURE_CODE,
+    INVALID_ARGUMENT_ERROR,
+    INVALID_REQUEST_ERROR,
+    STATEMENT_TYPE_ERROR
   ].includes(error.code)
 }
 
diff --git a/packages/bolt-connection/test/connection-provider/connection-provider-routing.test.js b/packages/bolt-connection/test/connection-provider/connection-provider-routing.test.js
@@ -1669,6 +1669,9 @@ describe.each([
       'Neo.ClientError.Database.DatabaseNotFound',
       'Neo.ClientError.Transaction.InvalidBookmark',
       'Neo.ClientError.Transaction.InvalidBookmarkMixture',
+      'Neo.ClientError.Request.Invalid',
+      'Neo.ClientError.Statement.ArgumentError',
+      'Neo.ClientError.Statement.TypeError',
       'Neo.ClientError.Security.Forbidden',
       'Neo.ClientError.Security.IWontTellYou'
     ])('with "%s"', errorCode => {
diff --git a/packages/neo4j-driver-deno/lib/bolt-connection/connection-provider/connection-provider-routing.js b/packages/neo4j-driver-deno/lib/bolt-connection/connection-provider/connection-provider-routing.js
@@ -48,6 +48,9 @@ const INVALID_BOOKMARK_MIXTURE_CODE =
   'Neo.ClientError.Transaction.InvalidBookmarkMixture'
 const AUTHORIZATION_EXPIRED_CODE =
   'Neo.ClientError.Security.AuthorizationExpired'
+const INVALID_ARGUMENT_ERROR = 'Neo.ClientError.Statement.ArgumentError'
+const INVALID_REQUEST_ERROR = 'Neo.ClientError.Request.Invalid'
+const STATEMENT_TYPE_ERROR = 'Neo.ClientError.Statement.TypeError'
 
 const SYSTEM_DB_NAME = 'system'
 const DEFAULT_DB_NAME = null
@@ -703,7 +706,10 @@ function _isFailFastError (error) {
   return [
     DATABASE_NOT_FOUND_CODE,
     INVALID_BOOKMARK_CODE,
-    INVALID_BOOKMARK_MIXTURE_CODE
+    INVALID_BOOKMARK_MIXTURE_CODE,
+    INVALID_ARGUMENT_ERROR,
+    INVALID_REQUEST_ERROR,
+    STATEMENT_TYPE_ERROR
   ].includes(error.code)
 }
 
