You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks good to me. @peterflynn did you still have concerns about removing the deprecated method in this sprint? I didn't see any conflicts with the filesystem API changes.
@jasonsanjose No, it's fine as far as the filesystem API changes go. The API was only deprecated in sprint 32, which isn't too long ago (definitely less time than we usually wait before removing deprecated APIs). But because we're in the special case of making larger breaking API changes this sprint anyway, maybe it's ok this time.
Ok, now I'm more strongly sure it's ok. Of the three extensions I'm aware of that were using this API when it became deprecated, only one is still using it (angularui.angularjs) and it will be broken in Sprint 34 either way (unless updated) due to filesystem changes.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the code for deprecated FileUtils.getFilenameExtension() as mentioned in Issue #5368: