You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is just two lines, but it makes a significant change, consider it a proposal
basically, when you do git push, husky runs prepush script and if it fails, it won't allow you to push unless you override it with a command line parameter
advantages are clear, people won't push any code that doesn't fit our settings, while disadvantage is that it slows down the push (but how often you push anyway?)
I think everything that keeps the code base clean and tidy is worth a look and try. I don't think that the additional check doesn't introduce a barrier for contributors.
I just love the idea of this check @zaggino π. I don't think it's going to slow down development as any sanity check failure has to be worked on immediately to pass the build. So either we work after a bad commit or while doing it. But this check can at least save a bad commit. I am all in for this π .
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is just two lines, but it makes a significant change, consider it a proposal
basically, when you do
git push
, husky runsprepush
script and if it fails, it won't allow you to push unless you override it with a command line parameteradvantages are clear, people won't push any code that doesn't fit our settings, while disadvantage is that it slows down the push (but how often you push anyway?)