| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 19 Jul 2025 15:50:48 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=408.754173,conversation_content-fragment;desc="conversation_content fragment";dur=1514.126862,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=247.188548,nginx;desc="NGINX";dur=1.286723,glb;desc="GLB";dur=101.448768
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=8XT1mCc%2FV2Y7Fjcrt3%2BpEHFQSejBImE6wtuO9mutAZ9HLxnylKK88TKs9461zmXwBQg7YR8HwY6EpdTbPWhnxwJoiAt6QwD7B5sNR2YhsDx4LVlXiGKPlkJimVSaLEqIESVSI5T8u1GbCC2sF4ECvStk0UFJUI9p99eaKp%2FzlRb4e0m3EdSxiWxDV4JMFPciYUjKKGxpWM%2Bhz%2F7QIQB%2BKH9ZeFdn8G%2B6QvWdf1JiQgLWk3GOXRkQYx6D6Gdo%2B%2B0hEagVkmlPxyheIYIkscziUg%3D%3D--s8eXSr77VoMHCMRn--ahZ8ZjE6Kcxepnro6T8TuQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.159297681.1752940246; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 15:50:46 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 15:50:46 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8B8C:E3E22:8FC5BD:BA6155:687BBED6
Update React to 0.14.7 and Immutable to 3.7.6. by petetnt · Pull Request #12035 · adobe/brackets · GitHub
petetnt
changed the title
Update React to 0.14.5 and Immutable to newest version
Update React to 0.14.7 and Immutable to 3.7.6.
Feb 13, 2016
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Update React to 0.14.7 and Immutable to 3.7.6. #12035
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great to upgrade. Always a lil scary due to tainted historical experience when the tree was first implemented. I will pull down this branch and help you test it. |
|
@MiguelCastillo Yup. Like I said, the this particular update is quite important as 0.13 -> 0.14 did contain tons of breaking changes. However the changes themselves are rather trivial to fix. That said this PR is (again) a bit outdated as React is already on 0.14.7. But as this PR fixes the critical things for an update path, upgrading to 0.14.x or 0.15 should be trivial. I'll update this PR later when I got some spare time. |
|
I am about to pull down your branch. It might be good to update to 0.14.7. :) |
|
@MiguelCastillo Bumped React to 0.14.7, Immutable to 3.7.6. All tests worked fine. |
petetnt
changed the title
| node.setSelectionRange(0, _getName(fullname, extension).length); | ||
| ViewUtils.scrollElementIntoView($("#project-files-container"), $(node), true); | ||
| ViewUtils.scrollElementIntoView($("#project-files-container"), $(ReactDOM.findDOMNode(node)), true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New behavior in 0.14 is that this.refs.name is the actual dom node. So ReactDOM.findDOMNode is redundant and no longer needed. Yay :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch: this was a brainfart due to it needing being needed @ L365 on componentDidUpdate because it targets this. Fixed.
|
The code is running ok right now. I will continue to run it for the rest of the day to see if I can catch any odd behavior. If all goes well, we can merge soon. |
|
In case there is an interest in changes between .14 and .13. https://facebook.github.io/react/blog/2015/10/07/react-v0.14.html |
|
PR is looking beautiful. Thanks for updating!! |
|
Looks good to me. Merging. |
MiguelCastillo
added a commit
that referenced
this pull request
Feb 14, 2016
Update React to 0.14.7 and Immutable to 3.7.6.
|
đź‘Ť neat. Thanks Miguel. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This PR updates React to the newest version of
0.14.5and Immutable to go with it.Updating React at this point is pretty crucial (IMO) if React is continued to be used: in 0.14 there were a lot of breaking changes that are still relatively easy to fix: biggest thing was how DOM-elements are being handled in React. For example: DOM operations like
renderare now being handled byReactDOM-module,getDOMNodehas been deprecated for the components,this.refs.componentrefreturns the DOM node directly instead of the component and so on.This PR also updates the tests involved: it fixes instances where TestUtils were used to find non-component (plain HTML) DOM Nodes and it also fixes all instances where
propswere being accessed instead of the DOM Nodes itself, which caused the following warnings:Warning: ReactDOMComponent: Do not access .props of a DOM node; instead, recreate the props asrenderdid originally or read the DOM properties/attributes directly from this node (e.g., this.refs.box.className).The PR has been done in backwards compatible fashion to the extent it is possible: extensions that are using deprecated methods and features should update themself before React on Brackets is updated to 0.15 some time in the future.