3.x: Rename zipIterable, remove zip(O(O)), adjust concatMapX arg order #6638

akarnokd · 2019-08-28T10:30:30Z

Rename zipIterable to zip
Remove zip(ObservableSource<ObservableSource<T>>) and zip(Publisher<Publisher<T>>)
Change the order of the tillTheEnd argument in concatMapDelayError and concatMapEagerDelayError to be consistent with other operators taking a boolean parameter before prefetch/maxConcurrency.

Related: #6610

codecov · 2019-08-28T10:46:43Z

Codecov Report

Merging #6638 into 3.x will decrease coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##                3.x    #6638      +/-   ##
============================================
- Coverage     98.16%   98.12%   -0.05%     
+ Complexity     6180     6174       -6     
============================================
  Files           678      678              
  Lines         44795    44779      -16     
  Branches       6177     6177              
============================================
- Hits          43975    43940      -35     
- Misses          279      291      +12     
- Partials        541      548       +7

Impacted Files	Coverage Δ	Complexity Δ
...operators/observable/ObservableInternalHelper.java	`100% <ø> (ø)`	`13 <0> (-1)`	⬇️
...nal/operators/flowable/FlowableInternalHelper.java	`100% <ø> (ø)`	`13 <0> (-1)`	⬇️
.../main/java/io/reactivex/rxjava3/core/Flowable.java	`100% <100%> (ø)`	`561 <4> (-1)`	⬇️
...ain/java/io/reactivex/rxjava3/core/Observable.java	`100% <100%> (ø)`	`537 <5> (-1)`	⬇️
...l/operators/observable/ObservableFlatMapMaybe.java	`86.8% <0%> (-9.03%)`	`2% <0%> (ø)`
...nternal/operators/observable/ObservableToList.java	`91.42% <0%> (-8.58%)`	`2% <0%> (-1%)`
...tivex/rxjava3/disposables/CompositeDisposable.java	`98.14% <0%> (-1.86%)`	`39% <0%> (-1%)`
...ernal/operators/flowable/FlowableFromIterable.java	`96.25% <0%> (-1.07%)`	`5% <0%> (ø)`
...perators/observable/ObservableMergeWithSingle.java	`99.07% <0%> (-0.93%)`	`2% <0%> (ø)`
...perators/single/SingleFlatMapIterableFlowable.java	`97.5% <0%> (-0.84%)`	`2% <0%> (ø)`
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faf6392...d273268. Read the comment docs.

3.x: Rename zipIterable, remove zip(O(O)), adjust concatMapX arg order

d273268

akarnokd added Cleanup 3.x Removal labels Aug 28, 2019

akarnokd added this to the 3.0 milestone Aug 28, 2019

akarnokd mentioned this pull request Aug 28, 2019

What's Different in 3.x (tracking issue) #6515

Closed

70 tasks

vanniktech approved these changes Aug 28, 2019

View reviewed changes

akarnokd merged commit f1441b0 into ReactiveX:3.x Aug 28, 2019

akarnokd deleted the OpNameAndArgCorrections3x branch August 28, 2019 11:19

akarnokd mentioned this pull request Aug 28, 2019

3.x: Change the parameter order of concatMap{Single|Maybe|Completable}DelayError #6610

Closed

akarnokd mentioned this pull request Sep 11, 2019

3.0.0-RC3 release preparations #6649

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

3.x: Rename zipIterable, remove zip(O(O)), adjust concatMapX arg order #6638

3.x: Rename zipIterable, remove zip(O(O)), adjust concatMapX arg order #6638

Uh oh!

akarnokd commented Aug 28, 2019 •

edited

Loading

Uh oh!

codecov bot commented Aug 28, 2019

Uh oh!

Uh oh!

3.x: Rename zipIterable, remove zip(O(O)), adjust concatMapX arg order #6638

3.x: Rename zipIterable, remove zip(O(O)), adjust concatMapX arg order #6638

Uh oh!

Conversation

akarnokd commented Aug 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Aug 28, 2019

Codecov Report

Uh oh!

Uh oh!

akarnokd commented Aug 28, 2019 •

edited

Loading