CARVIEW |
Select Language
HTTP/2 200
date: Sun, 20 Jul 2025 12:37:04 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=370.990103,conversation_content-fragment;desc="conversation_content fragment";dur=428.487457,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=219.465105,nginx;desc="NGINX";dur=1.330181,glb;desc="GLB";dur=95.086188
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=1yqsyubOTZIbUIDbSE8qyoMcYf5NcubYFan6Pv%2BSiDOtKu9c42SufjDQybOmU00NnZEDbpnSmpCs0UabFb1va2wpcrzjMleYEJ48A3Lg%2Fa0DJhTfOC5TkAB3WAKP5n8aK2Xj1sEeluY4XHQsH82%2FmWoiRjB%2Bvf7bFXb34B5UyA0CDIr%2F6CJicYh8zwKJCIA9%2B6KZCAXHkGiCUrQJebsTrxBDBPsHVbRysNPQJAOmt5xr%2Bxfwt%2BBFrZal%2Fr026%2BICG1HMfo3ARRUDEJWfuAdpWQ%3D%3D--lR0dv%2B4%2Ba5wg9rUY--8z58LYL20hjvy8J7lG%2FlUQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1064438999.1753015023; Path=/; Domain=github.com; Expires=Mon, 20 Jul 2026 12:37:03 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 20 Jul 2026 12:37:03 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E358:1C7ED6:513B91:6A86DF:687CE2EF
3.x: ConnectableFlowable/ConnetableObservabe redesign by akarnokd · Pull Request #6519 · ReactiveX/RxJava · GitHub
akarnokd
changed the title
3.x: ConnectableFlowable/ConnetableFlowable redesign
3.x: ConnectableFlowable/ConnetableObservabe redesign
Jun 19, 2019
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
3.x: ConnectableFlowable/ConnetableObservabe redesign #6519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.x #6519 +/- ##
===========================================
- Coverage 98.2% 98.17% -0.03%
- Complexity 6245 6247 +2
===========================================
Files 675 675
Lines 45051 45011 -40
Branches 6225 6211 -14
===========================================
- Hits 44241 44189 -52
- Misses 275 283 +8
- Partials 535 539 +4
Continue to review full report at Codecov.
|
70 tasks
This was referenced Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This PR changes the connectable API to have a specific
reset
method to reset a terminated connectable source as part of the official API.In 2.x, when
publish()
terminated, it reset itself to a fresh state which could lead to late consumers not receiving events as there might be no one to callconnect()
again (see #6501). However,replay()
did not reset itself, thus late consumers got the cached events, however, a reconnect started the sequence and new consumers may have missed items.In 3.x, this two corner cases have been fixed by the introduction of
reset()
. Bothpublish
andreplay
now remain in their terminated state untilreset
is called. If the connection is disposed, it will automatically reset their state just like before. The state transitions are as follows:connect()
-> running ->onComplete()
/onError()
-> terminated ->reset()
-> freshconnect()
-> running ->dispose()
-> freshconnect()
-> running ->onComplete()
/onError()
-> terminated ->dispose()
-> freshconnect()
-> running ->onComplete()
/onError()
-> terminated ->connect()
-> runningThis does resolve the race condition with
publish().refCount()
described in #6501.In addition, there are some changes to
Flowable.publish()
's behavior:It no longer keeps consuming the upstream if there are no subscribers. This implies if the source terminates while there are unconsumed items in the internal buffer, those will be available for observation.
I have no strong preference on this property and in comparison,
Observable.publish
drops items because there is no backpressure buffer in its implementation.Upstream errors are not reported to the
RxJavaPlugins.onError
handler when if there are no subscribers but have to be observed via a subscriber.Because terminal events are available until
reset
now, we can't know really if there is going to be a subscriber or not. However, it might be possible to detect the no-consumer case upon an error and still report it whenreset
ordispose
is called.Resolves #5628
Resolves #5899