| CARVIEW |
Select Language
HTTP/2 302
date: Sat, 19 Jul 2025 16:39:03 GMT
content-length: 0
location: https://github.com/NLnetLabs/unbound/pull/156
server-timing: nginx;desc="NGINX";dur=0.61703,glb;desc="GLB";dur=94.904083
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=wRwMZ0zfUmdh9DUG9fckNYAavdraXNl%2FKjxG%2F6x1lUw7zXVyM7SRGIqi%2BC9VpQvOtDoBZGlJTEVIbEpgrhPbM2zQdJdxa4Jdx5r9Dk4gcclHhUBiKQgVgKZ9G%2B%2BAfHRUz4WJ%2FRWSWUDqnbKf5tM9GO0HGHn3tFaTOqmkoCm0m5YOufDgV8ZnLUDb6%2B0K3HxUhWXfTcUWUfkf3khz%2BTspB3gNXSEDd6lwtCUg9vhQghK03cDDCOBY0ODZ4KTK%2B%2B%2Br%2BOdvR%2FmLRae4OdWPdByhuw%3D%3D--mWIRhy1bScr1Eibj--7ziGCeeUqSJKzREhoDTfSQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.578153286.1752943142; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 16:39:02 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 19 Jul 2026 16:39:02 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A4AC:2BEE38:6A6FF4:852ABE:687BCA26
HTTP/2 200
date: Sat, 19 Jul 2025 16:39:03 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=273.384225,conversation_content-fragment;desc="conversation_content fragment";dur=484.751872,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=264.497313,nginx;desc="NGINX";dur=0.774562,glb;desc="GLB";dur=96.820497
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: A4AC:2BEE38:6A7024:852AF6:687BCA26
Added unbound-control view_local_datas_remove command by n3bul4 · Pull Request #156 · NLnetLabs/unbound · GitHub
ralphdolmans
requested review from
ralphdolmans
and removed request for
wcawijngaards
January 29, 2020 10:21
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 396
Added unbound-control view_local_datas_remove command #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralphdolmans
requested review from
ralphdolmans
and removed request for
wcawijngaards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the code looks good.
One thing; the new command should be also be added to unbound-control.8.in.
ralphdolmans
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks
|
Parentheses is unbound-control.c:761 are incorrect, fixed in 5fcae2f |
n3bul4
added a commit
to n3bul4/FreeBSD-ports
that referenced
this pull request
Feb 10, 2020
The corresponding unbound functionality has already been merged to unbound master branch: NLnetLabs/unbound#156
n3bul4
added a commit
to n3bul4/FreeBSD-ports
that referenced
this pull request
Feb 11, 2020
dhcpleases sends a SIGHUP to unbound on every lease change to update DNS entries. This can lead to long unbound reload times, making DNS queries fail. This changes solve the problem by using unbound-control to update DNS entries. - kevent to exit when unbound exits - removed obsolete parameter -p (pidfile) - added bulk remove. See: NLnetLabs/unbound#156 - added usage See: Bug #5413
n3bul4
added a commit
to n3bul4/FreeBSD-ports
that referenced
this pull request
Feb 11, 2020
Use unbound-control to update DNS entries dhcpleases sends a SIGHUP to unbound on every lease change to update DNS entries. This can lead to long unbound reload times, making DNS queries fail. This changes solve the problem by using unbound-control to update DNS entries. - kevent to exit when unbound exits - removed obsolete parameter -p (pidfile) - added bulk remove. See: NLnetLabs/unbound#156 - added usage See: Bug #5413
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
I thought this would be a neat feature, to be able to bulk remove local_data from a view.